bugfix: update check4rotate

pylot/core/util/utils.py

@@ -165,11 +165,11 @@ def clims(lim1, lim2):
     """
     takes two pairs of limits and returns one pair of common limts
     :param lim1: limit 1
-    :type lim1: int
+    :type lim1: List[int]
     :param lim2: limit 2
-    :type lim2: int
+    :type lim2: List[int]
     :return: new upper and lower limit common to both given limits
-    :rtype: [int, int]
+    :rtype: List[int]
 
     >>> clims([0, 4], [1, 3])
     [0, 4]
@@ -536,8 +536,7 @@ def isSorted(iterable):
     >>> isSorted([2,3,1,4])
     False
     """
-    assert isIterable(iterable), 'object is not iterable; object: {' \
+    assert isIterable(iterable), "object is not iterable; object: {}".format(iterable)
-                                 '}'.format(iterable)
     if type(iterable) is str:
         iterable = [s for s in iterable]
     return sorted(iterable) == iterable
@@ -548,7 +547,7 @@ def isIterable(obj):
     takes a python object and returns True is the object is iterable and
     False otherwise
     :param obj: a python object
-    :type obj: object
+    :type obj: obj
     :return: True of False
     :rtype: bool
     """
@@ -929,66 +928,87 @@ def check4rotated(data, metadata=None, verbosity=1):
     :rtype: `~obspy.core.stream.Stream`
     """
 
-    def rotate_components(wfstream, metadata=None):
+    def rotation_required(trace_ids):
+        """
+        Derive if any rotation is required from the orientation code of the input.
+
+        :param trace_ids: string identifier of waveform data trace
+        :type trace_ids: List(str)
+        :return: boolean representing if rotation is necessary for any of the traces
+        :rtype: bool
+        """
+        orientations = [trace_id[-1] for trace_id in trace_ids]
+        return any([orientation.isnumeric() for orientation in orientations])
+
+    def rotate_components(wfs_in, metadata=None):
         """
         Rotate components if orientation code is numeric (= non traditional orientation).
 
         Azimut and dip are fetched from metadata. To be rotated, traces of a station have to be cut to the same length.
         Returns unrotated traces of no metadata is provided
-        :param wfstream: stream containing seismic traces of a station
+        :param wfs_in: stream containing seismic traces of a station
-        :type wfstream: `~obspy.core.stream.Stream`
+        :type wfs_in: `~obspy.core.stream.Stream`
         :param metadata: tuple containing metadata type string and metadata parser object
         :type metadata: (str, `~obspy.io.xseed.parser.Parser`)
         :return: stream object with traditionally oriented traces (ZNE)
         :rtype: `~obspy.core.stream.Stream`
         """
 
+        if len(wfs_in) < 3:
+            print(f"Stream {wfs_in=}, has not enough components to rotate.")
+            return wfs_in
+        
         # check if any traces in this station need to be rotated
-        trace_ids = [trace.id for trace in wfstream]
+        trace_ids = [trace.id for trace in wfs_in]
-        orientations = [trace_id[-1] for trace_id in trace_ids]
+        if not rotation_required(trace_ids):
-        rotation_required = [orientation.isnumeric() for orientation in orientations]
+            print(f"Stream does not need any rotation: Traces are {trace_ids=}")
-        if any(rotation_required):
+            return wfs_in
-            t_start = full_range(wfstream)
+
+        # check metadata quality
+        t_start = full_range(wfs_in)
         try:
-                azimuts = []
+            azimuths = []
             dips = []
             for tr_id in trace_ids:
-                    azimuts.append(metadata.get_coordinates(tr_id, t_start)['azimuth'])
+                azimuths.append(metadata.get_coordinates(tr_id, t_start)['azimuth'])
                 dips.append(metadata.get_coordinates(tr_id, t_start)['dip'])
-            except (KeyError, TypeError) as e:
+        except (KeyError, TypeError) as err:
-                print('Failed to rotate trace {}, no azimuth or dip available in metadata'.format(tr_id))
+            print(f"{type(err)=} occurred: {err=} Rotating not possible, not all azimuth and dip information "
-                return wfstream
+                  f"available in metadata. Stream remains unchanged.")
-            if len(wfstream) < 3:
+            return wfs_in
-                print('Failed to rotate Stream {}, not enough components available.'.format(wfstream))
+        except Exception as err:
-                return wfstream
+            print(f"Unexpected {err=}, {type(err)=}")
+            raise
+
         # to rotate all traces must have same length, so trim them
-            wfstream = trim_station_components(wfstream, trim_start=True, trim_end=True)
+        wfs_out = trim_station_components(wfs_in, trim_start=True, trim_end=True)
         try:
-                z, n, e = rotate2zne(wfstream[0], azimuts[0], dips[0],
+            z, n, e = rotate2zne(wfs_out[0], azimuths[0], dips[0],
-                                     wfstream[1], azimuts[1], dips[1],
+                                 wfs_out[1], azimuths[1], dips[1],
-                                     wfstream[2], azimuts[2], dips[2])
+                                 wfs_out[2], azimuths[2], dips[2])
             print('check4rotated: rotated trace {} to ZNE'.format(trace_ids))
             # replace old data with rotated data, change the channel code to ZNE
             z_index = dips.index(min(
-                    dips))  # get z-trace index, z has minimum dip of -90 (dip is measured from 0 to -90, with -90 being vertical)
+                dips))  # get z-trace index, z has minimum dip of -90 (dip is measured from 0 to -90, with -90
-                wfstream[z_index].data = z
+            # being vertical)
-                wfstream[z_index].stats.channel = wfstream[z_index].stats.channel[0:-1] + 'Z'
+            wfs_out[z_index].data = z
+            wfs_out[z_index].stats.channel = wfs_out[z_index].stats.channel[0:-1] + 'Z'
             del trace_ids[z_index]
             for trace_id in trace_ids:
                 coordinates = metadata.get_coordinates(trace_id, t_start)
                 dip, az = coordinates['dip'], coordinates['azimuth']
-                    trace = wfstream.select(id=trace_id)[0]
+                trace = wfs_out.select(id=trace_id)[0]
-                    if az > 315 or az <= 45 or az > 135 and az <= 225:
+                if az > 315 or az <= 45 or 135 < az <= 225:
                     trace.data = n
                     trace.stats.channel = trace.stats.channel[0:-1] + 'N'
-                    elif az > 45 and az <= 135 or az > 225 and az <= 315:
+                elif 45 < az <= 135 or 225 < az <= 315:
                     trace.data = e
                     trace.stats.channel = trace.stats.channel[0:-1] + 'E'
-            except (ValueError) as e:
+        except ValueError as err:
-                print(e)
+            print(f"{err=} Rotation failed. Stream remains unchanged.")
-                return wfstream
+            return wfs_in
 
-        return wfstream
+        return wfs_out
 
     if metadata is None:
         if verbosity: