Commit Graph
100 Commits
Author SHA1 Message Date
Darius Arnold 653e7c9b9a [remove] unused function for creating an error message for autopickstation tests 2018-07-20 15:05:42 +02:00
Darius Arnold 1b815a27b8 [add] HidePrint can be configured to skip hiding for quick debugging of tests 2018-07-20 15:04:48 +02:00
Darius Arnold 7fe5d0f7a3 [remove] Redundant checks for missing waveform data
Missing waveform data is now handled before picking starts, so it is not necessary to check during picking.
2018-07-20 14:50:27 +02:00
Darius Arnold 61b14dc770 [change] Create clean PickingResults instance with only required values
During picking, intermediary values were saved in p_results or s_results PickingResults instance.
Additionally the PickingResults class contained members that were only used during picking but not when returning the results, thus wasting space after picking, because they stayed in the instance. 
Now autopickstation generates a clean PickingResults containing only the members that are expected in the results.
2018-07-20 14:49:10 +02:00
Darius Arnold 153beff663 [add] tests for picking with missing trace in stream 2018-07-20 13:02:57 +02:00
Darius Arnold 318ca25ef8 [add] handling missing traces
either a missing vertical or missing both vertical traces in the wfstream will fail picking and return None. This is the same behaviour as before refactoring.
2018-07-20 13:00:19 +02:00
Darius Arnold 27f5a0d50c [remove] unused function, check was moved to init method
In the init method of autopickstation the N trace will be copied to the E trace or reversed if one of them is missing, so checking for it during S picking has become redundant.
2018-07-17 14:01:23 +02:00
Darius Arnold 85b34177c4 [add] default values for parameters of AutoPickStation init method 2018-07-17 13:59:46 +02:00
Darius Arnold 775d3de46c Change whitespace, add comments/documentation 2018-07-17 13:59:13 +02:00
Darius Arnold 6d26338f2e Decrease indentation in pick_s_phase
Instead of checking if(condition){DoSomething()}; check if (!condition){ErrorOut()}; DoSomething();.
This allows to decrease the indentation of the potentially large codeblock DoSomething().
2018-07-17 13:56:25 +02:00
Darius Arnold 02873938cb [change] minSlope value decreased due to difference in slope calculation 2018-07-17 11:37:29 +02:00
Darius Arnold c308415aa5 Move test_autopickstation to subdirectory in pylot/tests 2018-07-13 09:45:57 +02:00
Darius Arnold 2c92f6f2fd Merge branch 'develop' into feature/refactor 2018-07-13 09:28:50 +02:00
Darius Arnold 82ac08157c [bugfix] azimuth <45° was misattributed as E instead of N trace in check4rotated 2018-07-10 21:41:07 +02:00
Darius Arnold 51f2ded063 [add] basic unittests for Metadata class 2018-07-10 17:07:46 +02:00
Darius Arnold 1ff50c000e Decrease indentation by returning from error condition 2018-07-06 16:17:07 +02:00
Darius Arnold 71d8626fa3 [bugfix] parameters tpred2z and tdet2z were unused 2018-07-06 11:10:02 +02:00
Darius Arnold 67cf1f9010 Change tests to work with updated AIC 2018-07-06 10:51:50 +02:00
Darius Arnold b1a1e8924a Merging picker.py did not work correctly 2018-07-06 10:51:17 +02:00
Darius Arnold 5258a7e9b4 Merge remote-tracking branch 'origin/develop' into feature/refactor 2018-07-06 09:49:52 +02:00
Darius Arnold 4581025b4d Bugfix: typo l/1 in figure name 2018-07-03 13:56:29 +02:00
Darius Arnold 59e67b51d5 Bugfix where not giving origin with taupy would still use negative starttime 2018-07-03 13:55:51 +02:00
Darius Arnold 80835bc56e Transfer plotting of results in GUI after picking 2018-07-03 13:55:04 +02:00
Darius Arnold 86419220e2 Minor changes in autopick.py 2018-06-29 15:57:58 +02:00
Darius Arnold 68b2917e7f Refactor quality control of initial pick into own function 2018-06-29 15:56:32 +02:00
Darius Arnold d4e279aeba Refactor taupy usage 2018-06-29 14:21:03 +02:00
Darius Arnold fe1e76f53a Add correct way to put picking results even when picking fails, now passing all tests 2018-06-19 19:55:09 +02:00
Darius Arnold f4750472c7 Change PickingResults to inherit from dict and add dot access methods 2018-06-19 19:44:26 +02:00
Darius Arnold 675052975a Add finish_picking which transfers all results into the correct format in PickingResults
This function is called whether picking succeeded or failed. If it failed, it will put the default initialized values into the result. If picking succeeded, the default values will have been overwritten with the results during picking.
2018-06-19 19:38:13 +02:00
Darius Arnold e3f7840d9e Add S phase picking 2018-06-19 19:38:12 +02:00
Darius Arnold d4033eca08 Add converting fig_dict and iplot to the correct types 2018-06-19 19:33:22 +02:00
Darius Arnold 5b5da2e40d Move Trace Extraction to __init__ and copy over existing hor. trace if one is missing 2018-06-19 18:42:32 +02:00
Darius Arnold 7b6f64b46a Bugfixes/typos fixed during picking 2018-06-19 11:39:00 +02:00
Darius Arnold 335f3c4150 Replace access to trace over Stream index by direct access to trace attribute 2018-06-19 11:36:30 +02:00
Darius Arnold 0a1d15c429 Add PickingFailedException 2018-06-19 11:26:42 +02:00
Darius Arnold accb3c5d51 Add unittests for PickingResults 2018-06-19 11:20:57 +02:00
Darius Arnold 075b6e26c7 Modify test assertion to use DictContainsSubset and look at P and S seperately
With AssertDictContainsSubset the resulting dict from the new code can have more key/value pairs than the one from the old code, but all key/value pairs that are in the results from the old code must exist and be the same.
2018-06-19 11:19:49 +02:00
Darius Arnold 629bae63e2 [bugfix] wrong variable used during calculating length of waveform 2018-05-29 23:51:09 +02:00
Darius Arnold b0749e0ddc remove all usage of checkwindowP/S and minfactorP/S
Those changes have their own branch now, the parameters were not used during picking on this branch.
2018-05-29 21:28:32 +02:00
Darius Arnold 8d931fa97a [refactor] remove unnecessary if/else for earllatepicker 2018-05-29 21:27:11 +02:00
Darius Arnold ec9bce97ee [refactor] use existing functions to avoid repetition in autopickstation
DRY
2018-05-29 19:20:59 +02:00
Darius Arnold b93407012e [refactor] remove positional None argument in AICPicker instantiation
Instead use keyword arguments
2018-05-29 19:18:36 +02:00
Darius Arnold 1ffe4dcbb2 [minor] correct typos, add to docs, remove unnecessary parentheses 2018-05-29 19:14:41 +02:00
Darius Arnold a68cb9b0b7 [add] transfer P picking routine to new function 2018-05-29 19:08:06 +02:00
Darius Arnold 58191e2d8f [add] test for dot access in PickingParameter object 2018-05-29 19:04:51 +02:00
Darius Arnold 628f335b34 [refactor] get_quality_class uses generator expression
Can handy any size of list for weight_classes now
2018-05-29 19:02:58 +02:00
Darius Arnold c38e3eb07a [refactor] rename getQualityFromUncertainty function to be more pythonic 2018-05-29 18:53:38 +02:00
Darius Arnold 7910df3cc9 [add] tests for getQualityFromUncertainty function
Testing uncertainty in classes, between classes and outside of upper/lower bound of quality classes
2018-05-29 18:43:59 +02:00
Darius Arnold 2d850b70db Merge branch 'develop' into feature/refactor 2018-05-29 18:28:24 +02:00
Darius Arnold 756b5d67da [bugfix] getQualityFromUncertainty giving worst quality for uncertainty values between two classes
Now the quality classes are exclusive lower bound and inclusive upper bound.
2018-05-29 18:27:15 +02:00
Darius Arnold 82c0b7837c Add tests for creating of PickingParameters object from *args and **kwargs 2018-05-25 18:00:06 +02:00
Darius Arnold 0230f0bf2e Add object based approach to autopickstation: preparing traces, modifying cuttimes with taupy 2018-05-25 17:59:30 +02:00
Darius Arnold 9b787ac4e8 Add functions for splitting and preparing wfstream 2018-05-25 17:55:00 +02:00
Darius Arnold 02b7fae3df Minor formatting and docstring changes 2018-05-25 17:50:45 +02:00
Darius Arnold 15722c436e Merge remote-tracking branch 'origin/develop' into feature/refactor 2018-05-25 17:14:02 +02:00
Darius Arnold b220059e5b Move use_taupy and taupy_model from s_parameters to p_parameters 2018-05-25 12:28:15 +02:00
Darius Arnold 455733ea19 [Add] Unittest for autopickstation function picking with and without taupy 2018-05-22 19:21:29 +02:00
Darius Arnold 0366181532 [refactor] picking parameters into dictionaries 2018-04-17 11:53:47 +02:00
Darius Arnold 90e6c758d8 [bugfix] convert string response from qsettings to integer for calculation 2018-04-06 14:35:24 +02:00
Darius Arnold 1edc745903 Merge branch 'develop' into feature/refactor 2018-04-06 13:53:04 +02:00
Darius Arnold aba1a16f98 Merge branch 'feature/parameter_limits' into develop 2018-03-19 11:44:22 +01:00
Darius Arnold 8f78b6d8c8 [Add] Parameters clamped according to min/max values in default_parameters 2018-03-07 14:24:41 +01:00
Darius Arnold a44ada9938 [minor] correct misspelling in min value key in default_parameters 2018-03-07 14:23:36 +01:00
Darius Arnold ef8c19b747 Merge branch 'develop' into feature/parameter_limits 2018-03-07 11:16:37 +01:00
Darius Arnold b6fddaf208 [add] docstrings for event.py 2017-11-15 11:37:13 +01:00
Darius Arnold fc3a825e73 Merge remote-tracking branch 'origin/feature/refactor' into feature/refactor 2017-11-15 11:36:14 +01:00
Darius Arnold 983e4c25a3 [add] docstrings in pylot/core/loc 2017-11-13 11:45:25 +01:00
Darius Arnold 6aacd2dd55 [add] docstrings in pylot/core/io 2017-11-13 11:44:57 +01:00
Darius Arnold b2f211516a [change] docstrings in picker.py 2017-11-13 09:49:44 +01:00
Darius Arnold 16a8170e49 [add] an exception if unable to find minimum in AIC cf 2017-11-13 09:32:39 +01:00
Darius Arnold 8280a5043c [bugfix] snr calculation takes offset from cutting into account 2017-11-10 10:23:50 +01:00
Darius Arnold 887eeba6ec [minor] small docstring changes 2017-10-25 21:55:19 +02:00
Darius Arnold 8f721da643 refactoring picker.py (AICPicker and PragPicker) 2017-10-25 21:54:25 +02:00
Darius Arnold 149fe3f74d [change] docstrings in util/utils.py 2017-10-16 21:55:24 +02:00
Darius Arnold 7086d43076 [change] cleanup in pick/utils.py 2017-10-16 21:10:21 +02:00
Darius Arnold a5b3c5da1b [change] docstrings in pick/utils.py 2017-10-16 21:04:37 +02:00
Darius Arnold fab1f53a41 [change] docstrings in compare.py 2017-10-16 21:02:04 +02:00
Darius Arnold f1cd250cb1 [minor] one min/max key was forgotten in previous commit 2017-10-05 18:25:00 +02:00
Darius Arnold da6f35d76b [change] some tooltips for the picking parameters 2017-10-05 18:23:47 +02:00
Darius Arnold b10432f3bf [add] min/max values for most keys in default_parameters 2017-10-05 18:22:13 +02:00
Darius Arnold 9491a28710 [cleanup] of autoPyLoT.py 2017-10-05 17:26:18 +02:00
Darius Arnold 3dde42e639 [change] improved docstring for autopylot.py 2017-10-05 17:19:00 +02:00
Darius Arnold 87b4ce1345 [cleanup] in charfuns.py using code inspection 2017-10-05 16:52:36 +02:00
Darius Arnold 9a8d7da0e6 [change] docstrings for functions in charfuns.py 2017-10-05 16:50:53 +02:00
Darius Arnold 5931331b1d [cleanup] code cleanup in autopick.py using code inspection 2017-10-05 16:07:29 +02:00
Darius Arnold 6f65789844 [change] docstrings for functions in autopick.py 2017-10-05 16:06:11 +02:00
Darius Arnold c61277f429 [bugfix] pciking dialog initiated in arrayMap had no _style attribute 2017-10-04 16:52:18 +02:00
Darius Arnold 6d0083040c Merge branch 'feature/fix-tuneautopicker_stationlist' into develop 2017-09-15 20:49:38 +02:00
Darius Arnold 586abea874 [bugfix] same treatment of waveform data in tune autopicker and load waveform
fixes #217. While generating the station list for the tune autopicker dialog, waveform data was loaded and some traces were removed (gaps, doubled, rotated). However, not all the functions were called on wfdat, so some stations would be unavailable in the general waveform overview for the event, but could be selected in the tune autopicker.
2017-09-15 20:48:22 +02:00
Darius Arnold 2ee3c9a304 [change] show more stations in stationbox of tune autopicker dialog 2017-09-15 18:59:17 +02:00
Darius Arnold 2e6c33de45 [bugfix] allow picking of S phase in lower area of waveform plot
Fixes bug report #211
2017-09-15 18:56:04 +02:00
Darius Arnold 864f035456 Merge branch 'improve_jackwada_plots' into develop 2017-09-15 18:32:26 +02:00
Darius Arnold 27a6af6636 improved jackknife/median plot
added different colors to markers for accepted picks, jackknife reject picks and median rejected picks, added lines indicating median tolerance
2017-09-15 18:31:20 +02:00
Darius Arnold 62625d6941 improved wadati plot
added names of stations, added lines indicating wadati tolerance
2017-09-15 18:28:33 +02:00
Darius Arnold 7c528a4bfd [change] jackknife and wadati plot show one instead of two points in legend 2017-09-15 16:48:08 +02:00
Darius Arnold 8dc5be8e49 [bugfix] removed unneccessary command added during tight layout change 2017-09-15 16:47:12 +02:00
Darius Arnold a7fd239574 [bugfix] improvements to removal of NaNs during Cf calculation 2017-09-15 16:28:27 +02:00
Darius Arnold c8affae0c2 Merge branch 'tightlayout_tuneauto' into develop 2017-09-15 14:12:33 +02:00
Darius Arnold ec8d471ce1 [change] enabled tight layout for tune autopicker plots 2017-09-15 14:11:28 +02:00
Darius Arnold a96f8dcb7d [add] wadati, jackknife and median test print excluded stations 2017-09-15 13:24:13 +02:00