Sebastian Wehling-Benatelli sebastianw
  • Herdecke
  • Joined on 2021-01-31
sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-08-30 15:03:37 +02:00
e434bda993 [change] corrected for required versions
c0c3cbbd7b refactor: remove unused methods
76d4ec290c refactor: restructure data objects
63dac0fff6 refactor: restructure data objects
b15cfe2e1d bugfix: corrected for ValueError
Compare 31 commits »
sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-08-18 14:00:05 +02:00
9cc301e2c6 refactor: remove unused methods
sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-27 13:58:15 +02:00
65b456b8ab refactor: restructure data objects
sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-23 15:17:09 +02:00
0709fb04a5 refactor: restructure data objects
sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-23 13:47:06 +02:00
2515715193 bugfix: corrected for ValueError
sebastianw pushed to improve-util-utils at marcel/pylot 2024-07-22 14:48:34 +02:00
6cce05b035 Merge branch 'feature/dae' into develop
7326f061e5 [minor] inform if station coordinates were not found in metadata
1a18401fe3 [bugfix] added missing Parameter object in call for picksdict_from_picks
ec930dbc12 [minor] removed unneeded imports
b991f771af [bugfix] removing redundancy and wrong bullsh.. try-except code
Compare 43 commits »
sebastianw commented on pull request marcel/pylot#39 2024-07-20 10:44:54 +02:00
WIP: Simplify data structure

It is barely possible to restructure the data flow without touching the usage of the data objects. Thus, I suggest to refactor the entire PyLoT code and try to debug the following code blob…

sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-20 10:42:26 +02:00
a2add3034a refactor: rewrite plotWFData to reduce complexity
sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-20 10:30:26 +02:00
090bfb47d1 refactor: move Project definition to individual file
sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-20 10:23:53 +02:00
72f021cdc1 refactor: remove unused code; rewrite too complex functions
sebastianw commented on issue marcel/pylot#38 2024-07-17 14:14:24 +02:00
Remove unnecessary data structure complexity

HASH format is now missing in writephases needs to be re-implemented.

Done with [cb457fc7ec](marcel/pylot#39/commits/cb457fc7ec5b5260a0315cd9d4…

sebastianw commented on issue marcel/pylot#38 2024-07-17 14:12:08 +02:00
Remove unnecessary data structure complexity

Removed unnecessary code. Trying to get an overview of the data handling to be able to further simplify. These changes might break PyLoT in the first place but fixing makes it better than before.

sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-17 14:07:17 +02:00
e5c7404bb6 refactor: remove unnecessary additional declaration
1a148a8a72 suggestion: add new dataclasses; remove unused code
8623cc3dd3 refactor: removed unused code
Compare 3 commits »
sebastianw commented on issue marcel/pylot#38 2024-07-17 13:52:30 +02:00
Remove unnecessary data structure complexity

I just saw that obspy.io nowadays supports many of the file formats which are used by PyLoT. Instead of using untested self-written code, PyLoT should exploit the capabilities of obspy.

sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-17 13:29:21 +02:00
cb457fc7ec refactor: rename writephases; add write hash to write_phases
sebastianw commented on issue marcel/pylot#38 2024-07-16 14:55:58 +02:00
Remove unnecessary data structure complexity

HASH format is now missing in writephases needs to be re-implemented.

sebastianw pushed to 38-simplify-data-structure at marcel/pylot 2024-07-16 14:49:40 +02:00
eb077e4bd6 refactor: remove unused code; restructure writephases
sebastianw commented on issue marcel/pylot#38 2024-07-16 14:12:32 +02:00
Remove unnecessary data structure complexity

There is no difference between ObspyDMTdataStructure and PilotDataStructure. Why are both implemented?

sebastianw commented on issue marcel/pylot#38 2024-07-16 14:04:38 +02:00
Remove unnecessary data structure complexity

For actual implementation I would need a test data set. Alternatively, @marcel takes the implementation on this branch for testing purposes. Are there other data structures in use?

This is the…

sebastianw commented on issue marcel/pylot#38 2024-07-16 13:51:08 +02:00
Remove unnecessary data structure complexity

Design proposal:

  • separate data
    • event data
    • waveform data
  • remove structure
    • replace by data handlers for
      • event data
      • waveform data …